[Forwardport] FIX for issue #14849 - In Sales Emails no translation using order.getStatusLabel()#15770
Closed
sanjay-wagento wants to merge 3 commits intomagento:2.3-developfrom
sanjay-wagento:2.3-develop-PR-port-14914
Closed
[Forwardport] FIX for issue #14849 - In Sales Emails no translation using order.getStatusLabel()#15770sanjay-wagento wants to merge 3 commits intomagento:2.3-developfrom sanjay-wagento:2.3-develop-PR-port-14914
sanjay-wagento wants to merge 3 commits intomagento:2.3-developfrom
sanjay-wagento:2.3-develop-PR-port-14914
Conversation
…StatusLabel() \Magento\Sales\Model\Order\Config::getStatusLabel(), used by template email was forcing the usage of getLabel() when in adminhtml area. I added a new method getFrontendStatusLabel() in \Magento\Sales\Model\Order and modified email template files to use it instead of the original implementation. I did not modify the original implementation because still in use by backend and frontend.
magento-engcom-team
added
Partner: Wagento
Member
|
@VladimirZaets removing "on hold" label as the original pull request was merged. |
4 tasks
Contributor
|
Hi @sanjay-wagento. The original PR was merged, but the code in your PR is outdated. Please update the code according to original PR. Thanks! |
Contributor
|
Hi @sanjay-wagento, I am closing this PR now due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#14914
Description
\Magento\Sales\Model\Order\Config::getStatusLabel(), used by template email was forcing the usage of getLabel() when in adminhtml area.
I added a new method getFrontendStatusLabel() in \Magento\Sales\Model\Order and modified email template files to use it instead of the original implementation.
I did not modify the original implementation because still in use by backend and frontend.
Fixed Issues (if relevant)
Contribution checklist